build: Create internal rollup-utils package#9908
Merged
Conversation
added 12 commits
December 19, 2023 10:17
Contributor
Author
|
Only sentry internal eslint config changed. |
Lms24
approved these changes
Dec 19, 2023
packages/rollup-utils/index.mjs
Outdated
| @@ -0,0 +1,9 @@ | |||
| Error.stackTraceLimit = Infinity; | |||
Contributor
Author
There was a problem hiding this comment.
We already had this before. I believe this was so that we get bigger (ie not truncated) stack traces in case of an error.
Contributor
There was a problem hiding this comment.
This significantly affects the build performance.
Contributor
Author
There was a problem hiding this comment.
I can see that. Will remove. Stack traces during build are somewhat meh anyhow.
Lms24
reviewed
Dec 19, 2023
anonrig
reviewed
Dec 19, 2023
| "packages/remix", | ||
| "packages/replay", | ||
| "packages/replay-worker", | ||
| "packages/rollup-utils", |
Contributor
There was a problem hiding this comment.
Can we just make this build? If we move to a different package, we shouldn't change the package name
Contributor
Author
There was a problem hiding this comment.
I am gonna leave it at rollup-utils because that is what it is. build is too generic since building has many more steps than just calling some rollup utils.
packages/rollup-utils/index.mjs
Outdated
| @@ -0,0 +1,9 @@ | |||
| Error.stackTraceLimit = Infinity; | |||
Contributor
There was a problem hiding this comment.
This significantly affects the build performance.
added 2 commits
December 20, 2023 09:31
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As preparation for v8 and cleaning up our rollup configs to add
preserveModules: falsewithout needing to wipe the pain off our memories afterward this PR creates arollup-utilspackage.This PR doesn't change any functionality (see comment about checksums below). We can later move this package into a
dev-packagesfolder if we so desire.We had to change all of the rollup config files to mjs because of some package boundary stuff. This is hopefully a minor change though. It is also kinda good because rollup requires this in newer versions by default.