chore(biome): enable noUnusedImports rule#9895
Merged
AbhiPrasad merged 12 commits intodevelopfrom Dec 21, 2023
Merged
Conversation
anonrig
reviewed
Dec 18, 2023
| import type { WebFetchHeaders } from '@sentry/types'; | ||
| // @ts-expect-error Because we cannot be sure if the RequestAsyncStorage module exists (it is not part of the Next.js public | ||
| // API) we use a shim if it doesn't exist. The logic for this is in the wrapping loader. | ||
| // biome-ignore lint/nursery/noUnusedImports: Biome doesn't understand the shim with variable import path |
Contributor
There was a problem hiding this comment.
Can you also open an issue to Biome for this?
Contributor
Author
There was a problem hiding this comment.
Turns out that it's a typescript bug, so i refactored this code a little.
| import type { SpanContext } from '@sentry/types'; | ||
| import { render } from '@testing-library/react'; | ||
| import { renderHook } from '@testing-library/react-hooks'; | ||
| // biome-ignore lint/nursery/noUnusedImports: Need React import for JSXq |
Contributor
There was a problem hiding this comment.
Suggested change
| // biome-ignore lint/nursery/noUnusedImports: Need React import for JSXq | |
| // biome-ignore lint/nursery/noUnusedImports: Need React import for JSX |
Lms24
reviewed
Dec 19, 2023
Comment on lines
-2
to
-3
| // eslint-disable-next-line no-unused-vars | ||
| import * as _ from '@sentry/tracing'; |
Member
There was a problem hiding this comment.
I think we did this on purpose, not sure if the change is safe
Contributor
Author
There was a problem hiding this comment.
The change should be safe, I validated by running integration tests.
Contributor
Author
There was a problem hiding this comment.
nvm it isn't I reverted.
AbhiPrasad
commented
Dec 20, 2023
Comment on lines
-2
to
-3
| // eslint-disable-next-line no-unused-vars | ||
| import * as _ from '@sentry/tracing'; |
Contributor
Author
There was a problem hiding this comment.
The change should be safe, I validated by running integration tests.
| import type { WebFetchHeaders } from '@sentry/types'; | ||
| // @ts-expect-error Because we cannot be sure if the RequestAsyncStorage module exists (it is not part of the Next.js public | ||
| // API) we use a shim if it doesn't exist. The logic for this is in the wrapping loader. | ||
| // biome-ignore lint/nursery/noUnusedImports: Biome doesn't understand the shim with variable import path |
| import type { SpanContext } from '@sentry/types'; | ||
| import { render } from '@testing-library/react'; | ||
| import { renderHook } from '@testing-library/react-hooks'; | ||
| // biome-ignore lint/nursery/noUnusedImports: Need React import for JSXq |
| @@ -1,4 +1,3 @@ | |||
| import { get } from 'http'; | |||
Contributor
Author
There was a problem hiding this comment.
This was a bug that was caught from this, I'd rather we merge this sooner rather than later.
Contributor
Author
|
@anonrig this is ready for another review! |
anonrig
approved these changes
Dec 21, 2023
anonrig
pushed a commit
that referenced
this pull request
Dec 21, 2023
anonrig
pushed a commit
that referenced
this pull request
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds https://biomejs.dev/linter/rules/no-unused-imports/