fix(node): Guard process.env.NODE_ENV access in Spotlight integration#9748
Merged
fix(node): Guard process.env.NODE_ENV access in Spotlight integration#9748
process.env.NODE_ENV access in Spotlight integration#9748Conversation
b127120 to
2b0d67b
Compare
Contributor
size-limit report 📦
|
3 tasks
lforst
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like the spotlight integration code is possibly ending up in places it shouldn't.
While this PR doesn't adress this, it guards accessing
process.env.NODE_ENVwhich we should do anyway.Maybe addresses #8377 (comment)