Conversation
Lms24
commented
Dec 4, 2023
Contributor
size-limit report 📦
|
billyvg
approved these changes
Dec 4, 2023
Member
|
TIL about the checklist, great to know! |
Member
|
So I think what happened was that we were using an internal package version of feedback that was already published, and now we're releasing a new version (7.85.0), that has not been published. |
anonrig
reviewed
Dec 4, 2023
anonrig
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exporting user feedback via @sentry/browser (#9586) broke Remix and NextJS integration tests because they rely on local package resolutions. I'm not sure why CI didn't catch this but it's currently blocking the 7.85.0 release.
This PR adds the missing entries and updates the "New SDK/Package Release Checklist". Adding a package that's. a dependency of these framework SDKs happens so rarely that we probably didn't come across this yet.
Once this is merged we need to sync develop into master and then we can try publishing again