feat(feedback): Include Feedback package in browser SDK#9586
Merged
feat(feedback): Include Feedback package in browser SDK#9586
Conversation
2c7379e to
ac3ea44
Compare
Contributor
size-limit report 📦
|
mydea
approved these changes
Nov 20, 2023
mydea
previously requested changes
Nov 20, 2023
Member
mydea
left a comment
There was a problem hiding this comment.
oops, I think the before send stuff ended up here!
d18a401 to
dc08cec
Compare
dc08cec to
d9c7c22
Compare
Base automatically changed from
ref-feedback-remove-browser-imports
to
develop
November 20, 2023 22:22
d9c7c22 to
9922d7d
Compare
billyvg
commented
Nov 21, 2023
packages/browser/package.json
Outdated
| "access": "public" | ||
| }, | ||
| "dependencies": { | ||
| "@sentry-internal/feedback": "7.81.0", |
Member
Author
There was a problem hiding this comment.
@mydea Hmm the next/remix tests are failing -- should I put this at the published alpha package for now?
3ace58c to
bb53ece
Compare
1291314 to
27f0e59
Compare
Add feedback to craft publish list, and export `Feedback` integration from browser SDK
27f0e59 to
6daa463
Compare
44f9b9e to
758c1aa
Compare
The PR was blocked due to stacked changes (which have been merged)
AbhiPrasad
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add feedback to craft publish list, and export
Feedbackintegration from browser SDKDepends on
Relates to: https://github.com/getsentry/team-replay/issues/273