Merged
Conversation
Contributor
size-limit report 📦
|
1155a1b to
1f076b6
Compare
1f076b6 to
453d1c4
Compare
captureRemixServerException
AbhiPrasad
approved these changes
Dec 5, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Great, thanks for these changes @onurtemizkan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #9695
Should also resolve: #9563
Rewrote the error reporting logic of Remix SDK to handle inconsistencies, missing stack traces and potential duplications.
There are 5 main error types that we are concerned.
loaders andactionsAnd there are different points we can capture such as:
handleError,action / loader / documentRequestinstrumentationErrorBoundaryAn error is not guaranteed to end up only one of those utilities. Also the objects for the same error are not guaranteed to be the same in different places. That causes duplications.
So, with this patch, the new error handling / filtering logic for the instrumentation will be as below:
handleErrorloader/actionInstrumentationdocumentRequestInstrumentationErrorBoundary@sentry/reactErrorBoundaryloader/actionErrorsThis PR also adds:
Sentry.wrapRemixHandleErrorto be assigned ashandleErrorforentry.server(Needs docs / wizard support)