Conversation
AbhiPrasad
approved these changes
Nov 28, 2023
Contributor
|
Can you elaborate a bit more what impact this might have? I am worried about:
|
Contributor
Author
Definitely, @lforst
We already have enabled Biome plugin on
We don't add a new dependency. We already use Biome for formatting. We just enable the functionality of linting of Biome. |
Contributor
Author
|
@lforst I updated the VSCode settings. From now on, we don't need to have to ask developers to update VSCode settings for Biome specific actions. |
2057b81 to
165ba31
Compare
165ba31 to
10f8ab1
Compare
lforst
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables Biome linter and moves several rules to Biome.
Running
time yarn lintBefore
After