Skip to content

chore(astro): Allow Astro 4.0 in peer dependencies#9683

Merged
Lms24 merged 1 commit intodevelopfrom
lms/chore-astro-4.0-peer-dep-bump
Nov 28, 2023
Merged

chore(astro): Allow Astro 4.0 in peer dependencies#9683
Lms24 merged 1 commit intodevelopfrom
lms/chore-astro-4.0-peer-dep-bump

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 28, 2023 •
edited
Loading

Astro 4.0.0 beta is out so let's adjust our peer deps!
I opted for an open max version for now. There's a risk of this being problematic with future major versions but I'd argue we'd get support requests either way. The important part IMO is the lower bound.

@Lms24 Lms24 requested review from HazAT and lforst November 28, 2023 09:38
@Lms24 Lms24 merged commit f2e57ad into develop Nov 28, 2023
@Lms24 Lms24 deleted the lms/chore-astro-4.0-peer-dep-bump branch November 28, 2023 09:53
@silent1mezzo
Copy link

silent1mezzo commented Nov 28, 2023

@Lms24 This doesn't seem to actually fix the problem. Checking on https://semver.npmjs.com/ it doesn't include the 4.0 beta releases.

Screenshot 2023-11-28 at 2 22 32 PM

Trying to install @sentry/astro@7.83.0 into a project with astro@beta installed errors out on peer dependency

Screenshot 2023-11-28 at 2 32 12 PM

@Lms24
Copy link
Member Author

Lms24 commented Nov 29, 2023

@silent1mezzo thanks for raising! It seems this is related to beta/preview versions not being included in the >=[Major].x range. If you search for >=2.x, you'll also get 3.x versions. So I assume this is going to be resolved once a stable Astro 4.0 version is published.

I tried playing around with >=4.0.0-beta || >= 3.x but it also only gives me 3.x releases. Which is weird because only >=4.0.0-beta actually returns both 4.0.0 beta versions... Using the semver package, the range seems to be okay though. Maybe a bug in the website...

I'm temporarily gonna add the beta range to see if it solves this but all in all won't spend too much time on this though - the important thing is that we support 4.0 once it's stable.

@Lms24 Lms24 mentioned this pull request Nov 29, 2023
Merged
@Lms24 Lms24 mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HazAT HazAT HazAT approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24 @silent1mezzo @HazAT