fix(replay): Add BODY_PARSE_ERROR warning & time out fetch response load#9622
Merged
fix(replay): Add BODY_PARSE_ERROR warning & time out fetch response load#9622
BODY_PARSE_ERROR warning & time out fetch response load#9622Conversation
Contributor
size-limit report 📦
|
billyvg
approved these changes
Nov 21, 2023
|
@mydea Thank you very much for solving my problem in such a short time. After local testing, the network resource leakage problem was perfectly solved.😊 Finally, a little suggestion, I still hope to get bodySize when responseBodySize is undefined. 😊 const size =
bodyText && bodyText.length && responseBodySize === undefined
? getBodySize(bodyText, textEncoder)
: responseBodySize; |
Member
Author
I fear it is impossible to get the body size if no header is set AND we can't parse the body 😬 It'll be |
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tricky one 😬 Basically, it is possible that fetch returns a readable stream that is ongoing. So if we do
await response.text()this will be pending forever, if a stream is ongoing.I haven't found a way to really check that is the case and avoid parsing this at all 🤔 So the best I could come up with was to instead add a timeout of 500ms when we stop waiting for the fetch body.
This should at least unblock waiting on this, but it will still mean that the response continues to be parsed client-side - I don't think there is a way to abort this 🤔
Additionally, this also refactors this a bit so we add a new
BODY_PARSE_ERRORmeta warning if the parsing of the body fails, for whatever reason. we may also use this in the replay UI cc @ryan953 somehow?"fixes" #9616