ref(feedback): Remove isAnonymous option from feedback#9602
Merged
Conversation
Contributor
size-limit report 📦
|
billyvg
approved these changes
Nov 20, 2023
Member
billyvg
left a comment
There was a problem hiding this comment.
Does README need to be updated?
Contributor
Author
updating it now for isAnonymous, isNameRequired and isEmailRequired |
billyvg
approved these changes
Nov 20, 2023
Contributor
|
I think we're going to enforce squashing commits but we need to make sure that gitflow works properly with it first. In the time being @c298lee mind making sure you squash and merge your commits when merging PRs? We need to fix giving the option, but just in the short term. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove isAnonymous option from feedback because it clashes with sentry user
Closes #9585