ref: Hoist RequestData integration to @sentry/core#9597
Merged
Conversation
0218ec9 to
ce50a60
Compare
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hoists the
RequestDataintegration into@sentry/coreand all of its utility functions into@sentry/utils. In the process of this, I ended up merging the two versions of therequestdata.tsutility files we had (one in node and one in utils) to just leave us with the one in utils.We need to hoist the
RequestDataintegration to be able to use it in different runtime SDKs other than node.