test: Add loader test for unhandled promise rejection#9581
Merged
Conversation
lforst
approved these changes
Nov 16, 2023
Lms24
approved these changes
Nov 16, 2023
mydea
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 16, 2023
) This is actually handled in the SDK, so we don't have to double process this. And the processing in the loader is error prone, because we do not guard for what `p` could be. I checked and even in v6 this was already checked in the SDK (e.g. see here from 2 years ago: https://github.com/getsentry/sentry-javascript/blob/4cd71c5792453d16acd0137af7534fe9345abd93/packages/browser/src/integrations/globalhandlers.ts) Also saving a few bytes ;) Closes getsentry/sentry-javascript#9579 Test in SDK added here: getsentry/sentry-javascript#9581
erosiec
pushed a commit
to PixeeSandbox/sentry
that referenced
this pull request
May 14, 2025
…077) This is actually handled in the SDK, so we don't have to double process this. And the processing in the loader is error prone, because we do not guard for what `p` could be. I checked and even in v6 this was already checked in the SDK (e.g. see here from 2 years ago: https://github.com/getsentry/sentry-javascript/blob/4cd71c5792453d16acd0137af7534fe9345abd93/packages/browser/src/integrations/globalhandlers.ts) Also saving a few bytes ;) Closes getsentry/sentry-javascript#9579 Test in SDK added here: getsentry/sentry-javascript#9581
erosiec
pushed a commit
to PixeeSandbox/sentry
that referenced
this pull request
May 14, 2025
…077) This is actually handled in the SDK, so we don't have to double process this. And the processing in the loader is error prone, because we do not guard for what `p` could be. I checked and even in v6 this was already checked in the SDK (e.g. see here from 2 years ago: https://github.com/getsentry/sentry-javascript/blob/4cd71c5792453d16acd0137af7534fe9345abd93/packages/browser/src/integrations/globalhandlers.ts) Also saving a few bytes ;) Closes getsentry/sentry-javascript#9579 Test in SDK added here: getsentry/sentry-javascript#9581
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for getsentry/sentry#60077