fix(nextjs): Add tracing extensions in all serverside wrappers#9537
Merged
fix(nextjs): Add tracing extensions in all serverside wrappers#9537
Conversation
mydea
approved these changes
Nov 13, 2023
Member
mydea
left a comment
There was a problem hiding this comment.
This seems fine, maybe we find a way to abstract this away - e.g. can we export a wrapping startTransaction that basically does:
import { startTransaction as _startTransaction, addTracingExtensions } from '@sentry/core';
export function startTransaction() {
addTracingExtensions();
return _startTransaction(...arguments);
}And use this everywhere (or something like this)? Not sure how easy that would be in the next architecture...!
Contributor
Author
|
@mydea This doesn't seem like a bad idea. Maybe we have these wrappers for our server SDKs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues reported in #9461
This will add
addTracingExtension()calls to all auto instrumentation wrappers because they will attempt to start transactions and if the tracing extensions are not set the sdk will print an ugly warning.This is only serverside so bundlesize shouldn't matter here.