fix(tracing-internal): Fix case when originalURL contain query params#9531
Merged
AbhiPrasad merged 3 commits intogetsentry:developfrom Nov 20, 2023
LubomirIgonda1:fix-express-route-with-query-params
Merged
fix(tracing-internal): Fix case when originalURL contain query params#9531AbhiPrasad merged 3 commits intogetsentry:developfrom LubomirIgonda1:fix-express-route-with-query-params
AbhiPrasad merged 3 commits intogetsentry:developfrom
LubomirIgonda1:fix-express-route-with-query-params
Conversation
AbhiPrasad
suggested changes
Nov 10, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
thanks for the PR! One quick change
…or stripUrlQueryAndFragment function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix use case when original req url contain query params.
For example:
api/v1/users/posts?param=1Old behavior
sentry build req._reconstructedRoute as:
api/v1/users
New behavior
sentry build req._reconstructedRoute as:
api/v1/users/posts