Skip to content

feat(replay): Add feedback breadcrumb to replay#9495

Merged
billyvg merged 2 commits intodevelopfrom
feat-replay-create-feedback-crumb
Nov 9, 2023
Merged

feat(replay): Add feedback breadcrumb to replay#9495
billyvg merged 2 commits intodevelopfrom
feat-replay-create-feedback-crumb

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Nov 8, 2023

Add feedback breadcrumb to replay when a feedback is sent (and if replays are enabled).

Add feedback breadcrumb to replay when a feedback is sent (and if replays are enabled).
@billyvg billyvg marked this pull request as ready for review November 8, 2023 20:25
@billyvg billyvg requested a review from mydea November 8, 2023 20:27
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.33 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 55.57 KB (+0.17% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.98 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped) 21.3 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 61.9 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.1 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.24 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 195.23 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.32 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.3 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.81 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.69 KB (+0.13% 🔺)
@sentry/react - Webpack (gzipped) 21.34 KB (+0.03% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.42 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.13 KB (+0.02% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 15.98 KB (+1.06% 🔺)

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a test for this? 🤔 not blocking this, we can also add one later.

@billyvg
Copy link
Member Author

billyvg commented Nov 9, 2023

Yeah we still need to add some integration tests for feedback, will do so then!

@billyvg billyvg merged commit 432495d into develop Nov 9, 2023
@billyvg billyvg deleted the feat-replay-create-feedback-crumb branch November 9, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants