fix(nextjs): Trace with performance disabled#9389
Merged
Conversation
added 2 commits
October 27, 2023 11:13
Lms24
approved these changes
Oct 27, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
oof, seems like we have this guard in a bunch of places, not just NextJS :/
even made it to Astro
good catch!
Contributor
Author
|
@Lms24 All the other places I've seen make sense because of tree shaking. It's just that we should get rid of all the serverside checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We guarded a lot of tracing functionality in Next.js behind
hasTracingEnabled()which will prevent events from being traced when performance is disabled. This PR removes these checks, which were a relic of the past we missed when introducing "tracing without performance".