chore(angular-ivy): Allow Angular 17 in peer dependencies#9386
Merged
chore(angular-ivy): Allow Angular 17 in peer dependencies#9386
Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps our peer deps to allow for Angular 12-17 in the
@sentry/angular-ivypackage.With the improved SSR capabilities and Vite being used for SSR Angular apps during dev mode in Angular 17, there is still an issue with our SDK's package format (APF12) not being compatible with the server-side code. There is a workaround to fix this by only importing our SDK in the client side config but I reached out to the Angular team to find a proper solution.
Given that this bug only exists in SSR Angular apps, I'd argue we can already go ahead and make the peer dep bump.
I tested our SDK in a regular, client-only Angular 17 (RC2) app and errors, performance, replay and source maps seem to work. Angular 17 is scheduled to be released in the week of November 6th.
(Depending on the outcome of angular/angular-cli#26135, we might want to link to the workaround in docs but I'll hold off from doing this just now).