test(loader): Improve loader tests & update loader#9245
Merged
Conversation
lforst
approved these changes
Oct 13, 2023
Lms24
approved these changes
Oct 13, 2023
09c5fad to
b3d5482
Compare
Contributor
size-limit report 📦
|
b3d5482 to
4a04a2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the loader based on this PR: getsentry/sentry#58070
and also actually fixes/improves the loader tests by avoiding importing
@sentry/browser. This is not needed and actually obfuscates the "real"/"normal" behavior (just look at the generateddistfolder for a test.Instead, I added an eslint rule to allow
Sentryas a global for these cases, and just access them directly. This also uncovered an incorrect test, which I adjusted so it works. I also added a new test to ensure custom config works.