chore(astro): Add @sentry/astro package#9187
Merged
Conversation
Closed
lforst
approved these changes
Oct 6, 2023
HazAT
reviewed
Oct 6, 2023
Member
There was a problem hiding this comment.
Should we already add the Astro keywords?
https://docs.astro.build/en/reference/publish-to-npm/#keywords
Member
Author
There was a problem hiding this comment.
I initially wanted to wait until we have something usable but then again, we'll iterate fast, so we can add it now, too.
Member
Author
There was a problem hiding this comment.
I opted for a separate PR because I had to configure the package as public to get our e2e tests working. We can merge whenever we feel comfortable with actually publishing the package.
#9193
AbhiPrasad
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the boilerplate files for the new
@sentry/astropackage. Amongst the usual files, some noteworthy things include:ref #9182