feat(serverlesss): allow disabling transaction traces#9154
Merged
AbhiPrasad merged 2 commits intogetsentry:developfrom Oct 12, 2023
Merged
feat(serverlesss): allow disabling transaction traces#9154AbhiPrasad merged 2 commits intogetsentry:developfrom
AbhiPrasad merged 2 commits intogetsentry:developfrom
Conversation
5586348 to
093da76
Compare
AbhiPrasad
reviewed
Oct 12, 2023
093da76 to
ad72d86
Compare
AbhiPrasad
approved these changes
Oct 12, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Thanks a lot @aldenquimby - appreciate the PR!
Release either comes out tomorrow or on Monday - let's see how CI feels 😭
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Background
@sentry/nodetoday, and tried adding@sentry/serverlessfor it's timeout warning, auto-handling offlush, and links to cloudwatch logsProposal
startTransactionboolean flag that turns on/off the transaction tracing feature of@sentry/serverless@sentry/serverless, but still rely on expresstracingHandlerfor performance tracesAlternatives
For reviewers