feat: Support exactOptionalPropertyTypes on ErrorBoundary#9098
Merged
lforst merged 1 commit intogetsentry:developfrom Nov 28, 2023
quisido:patch-1
Merged
feat: Support exactOptionalPropertyTypes on ErrorBoundary#9098lforst merged 1 commit intogetsentry:developfrom quisido:patch-1
exactOptionalPropertyTypes on ErrorBoundary#9098lforst merged 1 commit intogetsentry:developfrom
quisido:patch-1
Conversation
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Contributor
Author
|
Please review 🙏 |
Contributor
Author
Contributor
|
Sorry, this slipped through. We don't have proper channels in place for community PRs and we need to improve this. I will look at this PR |
exactOptionalPropertyTypes on ErrorBoundaryexactOptionalPropertyTypes on ErrorBoundary
lforst
approved these changes
Nov 27, 2023
Contributor
Author
|
@lforst Thank you. I rebased through the PR UI. Hopefully it's mergeable soon. |
lforst
approved these changes
Nov 28, 2023
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript has a
exactOptionalPropertyTypesflag that uses stricter typing on objects.type T = { property?: V }meansT['property'] Vor!('property' in T), butT['property']cannot=== undefined.This means that consumers of
@sentry/reactwho haveexactOptionalPropertyTypesenabled cannot set anErrorBoundaryprop toundefinedwithout hard-failing TypeScript transpilation.This PR attempts to fix that.