fix(sveltekit): Adjust `handleErrorWithSentry` type by krist7599555 · Pull Request #9054 · getsentry/sentry-javascript

krist7599555 · 2023-09-19T19:21:58Z

handleErrorWithSentry, which is wrapper function, should be identity function (f(x) => x).

Implementation is fine, just the type mismatch from implementation.

sentry-javascript/packages/sveltekit/src/server/handleError.ts

Lines 22 to 41 in cd0bc3b

    
           export function handleErrorWithSentry(handleError: HandleServerError = defaultErrorHandler): HandleServerError { 
        
             return (input: { error: unknown; event: RequestEvent }): ReturnType<HandleServerError> => { 
        
               if (isNotFoundError(input)) { 
        
                 return handleError(input); 
        
               } 
        
               captureException(input.error, scope => { 
        
                 scope.addEventProcessor(event => { 
        
                   addExceptionMechanism(event, { 
        
                     type: 'sveltekit', 
        
                     handled: false, 
        
                   }); 
        
                   return event; 
        
                 }); 
        
                 return scope; 
        
               }); 
        
               return handleError(input); 
        
             }; 
        
           }

handleErrorWithSentry should be identity function `f(x) => x` as a wrapper function

Lms24

Hi @krist7599555 thanks for contributing! Good catch!

(I fixed the linter error but other than that, this is good to go. We'll include this in today's release)

AbhiPrasad · 2023-09-20T12:03:18Z

Fix was released with with https://github.com/getsentry/sentry-javascript/releases/tag/7.70.0. Thanks for your contribution @krist7599555!

krist7599555 and others added 2 commits September 20, 2023 02:15

fix(sveltekit): type handleErrorWithSentry is wrong

bbb8ce3

handleErrorWithSentry should be identity function `f(x) => x` as a wrapper function

fix linter

e827f49

Lms24 changed the title ~~fix(sveltekit): type handleErrorWithSentry is wrong~~ fix(sveltekit): Adjust handleErrorWithSentry type Sep 20, 2023

Lms24 approved these changes Sep 20, 2023

View reviewed changes

Lms24 merged commit 5f7df8c into getsentry:develop Sep 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(sveltekit): Adjust `handleErrorWithSentry` type#9054

fix(sveltekit): Adjust `handleErrorWithSentry` type#9054
Lms24 merged 2 commits intogetsentry:developfrom
krist7599555:patch-1

krist7599555 commented Sep 19, 2023

Uh oh!

Lms24 left a comment •

edited

Loading

Uh oh!

AbhiPrasad commented Sep 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	export function handleErrorWithSentry(handleError: HandleServerError = defaultErrorHandler): HandleServerError {
	return (input: { error: unknown; event: RequestEvent }): ReturnType<HandleServerError> => {
	if (isNotFoundError(input)) {
	return handleError(input);
	}

	captureException(input.error, scope => {
	scope.addEventProcessor(event => {
	addExceptionMechanism(event, {
	type: 'sveltekit',
	handled: false,
	});
	return event;
	});
	return scope;
	});

	return handleError(input);
	};
	}

Uh oh!

Conversation

krist7599555 commented Sep 19, 2023

Uh oh!

Lms24 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AbhiPrasad commented Sep 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lms24 left a comment •

edited

Loading