test(e2e): Decode gzipped envelopes in E2E tests#8926
Merged
Conversation
lforst
commented
Aug 31, 2023
|
|
||
| .vscode | ||
|
|
||
| test-results |
Contributor
Author
There was a problem hiding this comment.
If tests fail locally traces are dumped here
| "@types/react": "18.0.26", | ||
| "@types/react-dom": "18.0.9", | ||
| "next": "13.2.4", | ||
| "next": "13.4.19", |
Contributor
Author
There was a problem hiding this comment.
Tests are actually failing in this version because of this. Only noticed because of our canary tests.
Lms24
approved these changes
Sep 1, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Nice!
Side note: At some point we should really think about a dev-utils package. We have a similar decompression logic in the browser-integration-tests package due to replay envelopes being compressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes our E2E test proxy decode gzipped envelopes.
This change is motivated by Next.js compressing requests in dev mode 🤷♂️. It also lets us re-enable a few tests I thought were just broken.