feat(node-experimental): Implement new performance APIs#8911
Merged
Conversation
Member
Author
c5e2347 to
ad8507a
Compare
AbhiPrasad
approved these changes
Aug 31, 2023
ad8507a to
03f20f6
Compare
AbhiPrasad
added a commit
that referenced
this pull request
Sep 11, 2023
Based on #8911 and convos in slack, it was brought up that we might need to expose a method that works similar to `startSpan`, but that does not automatically finish the span at the end of the callback. This is necessary when you have event emitters (`res.once`) or similar. ```ts Sentry.startSpanManual(ctx, (span, finish) => { // do something with span // when you're done, call finish() finish(); }); ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-implements the new performance APIs:
startActiveSpanstartSpangetActiveSpanIn
@sentry/node-experimental, where these delegate to OTEL under the hood.I tried to make sure to have exactly the same APIs as we have for these functions without this. There are some caveats with this:
span.finish()may behave in unexpected ways - it is not supported to manually finish a span.scope.getSpan()will not workspan.startSpan()will not workBasically, only the top level exported methods work, nothing else.