meta(changelog): Update changelog for 7.66.0#8896
Merged
Conversation
[Gitflow] Merge master into develop
While looking into logger issues, I noticed that we fill console.xxx multiple times. This PR changes that so that we use the console instrumentation from utils in all cases.
…mentation (#8881) In our auto instrumentation Vite plugin for SvelteKit, we read `+(page|layout)(.server).(js|ts)` files' code to determine if we should add our wrapper to the file or not. We previously didn't check for a file id's existence before reading the file if the id matched that certain pattern, wrongly assuming that these ids would always map to actually existing files. It seems like Vite plugins such as Houdini's plugin add file ids to the build for files that actually don't exist (#8846, #8854) . When our plugin's `load` hook was called for such an id, it then tried to access and read the file which caused a build error. This patch now adds a file existence guard to ensure we simply no-op for these files.
Noticed that this is a bit tightly coupled in the browser client, and could be simplified by using a hook.
This adds an `origin` to all spans, which defaults to `manual` but is set to something more meaningful for all our auto instrumentation. I tried to come up with reasonable origin names, I hope it makes sense everywhere 😅 Also note that this now uses a new TS feature which seems to be correctly transpiled to TS 3.8, as far as I can tell! 🎉 Closes #8510 --------- Co-authored-by: Luca Forstner <luca.forstner@sentry.io> Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Contributor
size-limit report 📦
|
Contributor
|
Why is this a minor? There are only fixes here. |
AbhiPrasad
reviewed
Aug 29, 2023
Comment on lines
+12
to
+14
| - ref: Use consistent console instrumentation (#8879) | ||
| - ref(browser): Refactor sentry breadcrumb to use hook (#8892) | ||
| - ref(tracing): Add `origin` to spans (#8765) |
Contributor
There was a problem hiding this comment.
Suggested change
| - ref: Use consistent console instrumentation (#8879) | |
| - ref(browser): Refactor sentry breadcrumb to use hook (#8892) | |
| - ref(tracing): Add `origin` to spans (#8765) | |
| - ref(tracing): Add `origin` to spans (#8765) |
Contributor
Author
There was a problem hiding this comment.
I wanted to leave these in because they non-trivially touch our console instrumentation and somebody with issues might find the changelog entry useful (in case there are any issues).
But I can remove the entries if you feel strongly about it.
Contributor
Author
@AbhiPrasad #8892 expands the API |
AbhiPrasad
approved these changes
Aug 29, 2023
Lms24
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.