Skip to content

ref(browser): Refactor sentry breadcrumb to use hook#8892

Merged
mydea merged 1 commit intodevelopfrom
fn/use-hooks-breadcrumbs
Aug 29, 2023
Merged

ref(browser): Refactor sentry breadcrumb to use hook#8892
mydea merged 1 commit intodevelopfrom
fn/use-hooks-breadcrumbs

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented Aug 29, 2023

Noticed that this is a bit tightly coupled in the browser client, and could be simplified by using a hook.

@mydea mydea requested review from AbhiPrasad and lforst August 29, 2023 12:10
@mydea mydea self-assigned this Aug 29, 2023
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.23 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.22 KB (+0.06% 🔺)
@sentry/browser - Webpack (gzipped) 21.86 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.76 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.18 KB (-0.11% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.19 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.02 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.85 KB (-0.05% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.84 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.07 KB (-0.11% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.25 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 21.89 KB (+0.06% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.09 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.75 KB (+0.04% 🔺)

@mydea mydea merged commit e72c047 into develop Aug 29, 2023
@mydea mydea deleted the fn/use-hooks-breadcrumbs branch August 29, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants