Merged
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Aug 14, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
let's do it!
not sure why these don't get used anymore either, but if all the tests pass I'm confident.
It _seems_ they do not do anything - at least I compared the complete build ouput for node, core & browser with & without this, and it appeared _exactly_ the same.
c32c0f3 to
f21d0fc
Compare
|
Hi @mydea / @AbhiPrasad, Might this be related to these changes? I just upgraded to 7.65.0 when, during a nextjs build, every page fails due to several resolve errors (not limited to 'fs') all coming from Sentry. If you need any more info, let me know. |
Contributor
|
@bjarn this will be fixed in 7.66.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems they do not do anything - at least I compared the complete build ouput for node, core & browser with & without this, and it appeared exactly the same.
Not sure, maybe I missed something, it is not entirely clear to me how/what/when these would be applied etc.