Conversation
Contributor
size-limit report 📦
|
fb9f13e to
43363e8
Compare
Member
|
Don't mind me, just passing through: EDIT: I wonder though if it works for Webpack too 🤔 if it does, we might be able to do the same thing in our logger instead of always guarding the calls 🤔 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This streamlines & improves logging for replay status, adding more logs for certain things to be better able to see what's going on, and adapting the
traceInternalssetting to result in console breadcrumbs being added (which should show up both in replay and for e.g. sentry errors etc).While at it I also fixed some
anyeslint warnings in replay.ref: #8400