fix(node-experimental): Update auto integration lookup & readme#8690
Merged
fix(node-experimental): Update auto integration lookup & readme#8690
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Aug 1, 2023
| There is experimental support for running OpenTelemetry with ESM (`"type": "module"`): | ||
|
|
||
| ```bash | ||
| node --experimental-loader=@opentelemetry/instrumentation/hook.mjs ./app.js |
Member
Author
There was a problem hiding this comment.
yes, so sad 😬 and even that doesn't work with all integrations, e.g. it fails with fastify. 😢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the way we auto-lookup integrations.
Due to how OTEL instrumentation works, we actually do not need any dynamic require. Otel instrumentation will generally always work, it only actually instruments when something is required/imported. So all integration will be added, they will simply do nothing if the package is not used.
This also updates the readme to clarify this & restrictions.