fix(tracing): Trim idle transaction spans if they exceed final timeout#8653
Merged
AbhiPrasad merged 5 commits intodevelopfrom Jul 27, 2023
Merged
fix(tracing): Trim idle transaction spans if they exceed final timeout#8653AbhiPrasad merged 5 commits intodevelopfrom
AbhiPrasad merged 5 commits intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
Contributor
|
Dropping the span that goes over the final timeout sounds like a good quick solution. 👍 |
6adbbb4 to
b44cdd9
Compare
Lms24
approved these changes
Jul 27, 2023
krystofwoldrich
approved these changes
Jul 27, 2023
Contributor
krystofwoldrich
left a comment
There was a problem hiding this comment.
Looks good. 🚀
I think maybe we should fo a small troubleshooting docs update for people running into the long Tx.
Contributor
Author
Good idea, let me put in my todo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #8505
resolves #8504
If an idle transaction's duration is longer than final timeout + idle timeout, opt to not capture and send it to Sentry.