Skip to content

fix(core): Drop long idle transactions#8505

Closed
AbhiPrasad wants to merge 1 commit intodevelopfrom
abhi-drop-long-idle-transactions
Closed

fix(core): Drop long idle transactions#8505
AbhiPrasad wants to merge 1 commit intodevelopfrom
abhi-drop-long-idle-transactions

Conversation

@AbhiPrasad
Copy link
Contributor

resolves #8504

If an idle transaction's duration is longer than final timeout + idle timeout, opt to not capture and send it to Sentry.

This should help prevent transactions with durations that don't make sense (too long).

Current issues:

  1. this breaks distributed tracing
  2. idk how to test it

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.95 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 69.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 60.38 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.9 KB (0%)
@sentry/browser - Webpack (minified) 71.51 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.62 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 30.15 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 28.18 KB (+0.16% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.42 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 43.1 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.54 KB (+0.06% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.82 KB (0%)

@AbhiPrasad AbhiPrasad closed this Jul 26, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-drop-long-idle-transactions branch July 26, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IdleTransaction duration should not exceed final timeout

1 participant