feat(tracing): Add PropagationContext to scope #8421
Merged
AbhiPrasad merged 10 commits intodevelopfrom Jun 29, 2023
Merged
Conversation
Contributor
Author
|
I know this needs more tests, I'm planning to add some integration tests after some more twp tasks are merged in. |
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jun 29, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
LGTM! Good point about tests and I agree that it's better to wait until all important parts are implemented and then add integration tests.
| } | ||
| if (captureContext.propagationContext) { | ||
| this._propagationContext = captureContext.propagationContext; | ||
| } |
Member
There was a problem hiding this comment.
Hmm seems like we have quite some duplicated logic here when distinguishing between captureContext being a class instance or a plain object. No action required in this PR but we should probable deduplicate this.
Contributor
Author
There was a problem hiding this comment.
Yeah something we can keep in mind, I'll leave a note.
| ); | ||
| }); | ||
|
|
||
| test('it adds a trace context all events', () => { |
Member
There was a problem hiding this comment.
super-l:
Suggested change
| test('it adds a trace context all events', () => { | |
| test('it adds a trace context to all events', () => { |
Contributor
Author
There was a problem hiding this comment.
Will update in the next PR!
AbhiPrasad
added a commit
that referenced
this pull request
Jun 29, 2023
Requires #8421 to be merged ref #8352 This PR adds support for https://github.com/getsentry/rfcs/blob/main/text/0071-continue-trace-over-process-boundaries.md via propagation context. When the Node SDK initializes, it grabs `process.env.SENTRY_TRACE` and `process.env.SENTRY_BAGGAGE` and uses them to populate the existing propagation context. In future PRs (tracked by #8352), we will be adding support for transactions/outgoing requests to use propagation context, but for now we are only storing in propagation context, not doing anything with it.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #8352
For more details about PropagationContext, see https://www.notion.so/sentry/Tracing-without-performance-efab307eb7f64e71a04f09dc72722530
Building off of work in both #8403 and #8418, this PR adds
PropagationContextand uses that to always set a trace context on outgoing error events.Currently if there is an active span on the scope, we automatically attach that span's trace context to all outgoing events. Now, we want to rely on either the active span or fallback to the propagation context to ensure that there is always a trace being generated and propagated.
Next up we'll work on updating the node/browser SDKs to update the propagation context. For example, we should update the propagation context for node based on the incoming sentry-trace/baggage headers.