fix(utils): Normalize undefined to undefined instead of "[undefined]"#8017
Merged
fix(utils): Normalize undefined to undefined instead of "[undefined]"#8017
undefined to undefined instead of "[undefined]"#8017Conversation
undefined to undefined instead of "undefined"undefined to undefined instead of "[undefined]"
Contributor
size-limit report 📦
|
mydea
approved these changes
May 3, 2023
Member
mydea
left a comment
There was a problem hiding this comment.
I was wondering before why we even had that in the first place - IMHO usually you'll not care to see this, as it should be identical to not having this, and when JSON stringifying undefined things are normally dropped. You'll have some more tests to fix, though 😅
Lms24
approved these changes
May 3, 2023
packages/utils/src/normalize.ts
Outdated
Comment on lines
+83
to
+84
| value === undefined || | ||
| value === null || |
Member
There was a problem hiding this comment.
super-l (just with bundle size in mind but feel free to ignore):
Suggested change
| value === undefined || | |
| value === null || | |
| value == null || |
This should be identical, just a little shorter, right?
Contributor
Author
There was a problem hiding this comment.
You're right. I even thought about this but I stopped micro-optimizing for bundle because I assume terser will optimize this stuff away anyhow. Here I am still gonna go with your change because I don't know if it catches ths.
added 3 commits
May 3, 2023 09:30
|
|
||
| test('primitive values in objects/arrays', () => { | ||
| expect(normalize(['foo', 42, undefined, NaN])).toEqual(['foo', 42, '[undefined]', '[NaN]']); | ||
| expect(normalize(['foo', 42, NaN])).toEqual(['foo', 42, '[NaN]']); |
Contributor
There was a problem hiding this comment.
I'm just thinking why not keep the undefined here?
Suggested change
| expect(normalize(['foo', 42, NaN])).toEqual(['foo', 42, '[NaN]']); | |
| expect(normalize(['foo', 42, undefined, NaN])).toEqual(['foo', 42, undefined, '[NaN]']); |
I would expect this to pass, or not?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7933
Supersedes #8009
It's a bit weird that undefined normalizes to a string and even causes issues for users (see #7933). I suggest we change this.