feat(replay): Add event to capture options on checkouts#8011
Merged
feat(replay): Add event to capture options on checkouts#8011
Conversation
Member
Author
|
@mydea Thoughts on this approach? Not sure if it's better here or when we flush |
mydea
reviewed
May 2, 2023
mydea
reviewed
May 2, 2023
Comment on lines
+123
to
+124
| networkRequestHeaders: options.networkRequestHeaders.length > 0, | ||
| networkResponseHeaders: options.networkResponseHeaders.length > 0, |
Member
There was a problem hiding this comment.
Suggested change
| networkRequestHeaders: options.networkRequestHeaders.length > 0, | |
| networkResponseHeaders: options.networkResponseHeaders.length > 0, | |
| networkRequestHasHeaders: options.networkRequestHeaders.length > 0, | |
| networkResponseHasHeaders: options.networkResponseHeaders.length > 0, |
? for symmetry, maybe?
Member
There was a problem hiding this comment.
I was looking at the config but maybe this changed...
It looks like req & resp either both have headers, bo both do not. But these two fields networkRequestHasHeaders and networkResponseHasHeaders makes it seem like there could be an XOR kind of case, where one has headers and the other doesn't?
Member
Author
There was a problem hiding this comment.
@ryan953 yeah it's possible we have an XOR case
Member
There was a problem hiding this comment.
these fields tell us if users have configured additional headers for request/response.
mydea
reviewed
May 2, 2023
Member
Author
|
Tests still need some work, it's going to be a bit annoying because it's testing against the stringified payload and ordering needs to be exact :( |
mydea
reviewed
May 2, 2023
Contributor
size-limit report 📦
|
mydea
reviewed
May 2, 2023
Add a custom event that captures configuration options on checkout + segment 0.
7020963 to
16e575a
Compare
billyvg
commented
May 5, 2023
mydea
reviewed
May 5, 2023
mydea
reviewed
May 5, 2023
mydea
approved these changes
May 5, 2023
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a custom event that captures configuration options on checkout + segment 0.
Closes #7140
Closes #8004