Skip to content

fix(node): Mark stack frames with url protocol as in-app frames#8008

Merged
lforst merged 5 commits intodevelopfrom
lforst-node-url-inapp
May 3, 2023
Merged

fix(node): Mark stack frames with url protocol as in-app frames#8008
lforst merged 5 commits intodevelopfrom
lforst-node-url-inapp

Conversation

@lforst
Copy link
Copy Markdown
Contributor

@lforst lforst commented May 2, 2023

@lforst lforst mentioned this pull request May 2, 2023
Closed
@lforst lforst requested review from AbhiPrasad, Lms24 and mydea May 2, 2023 09:45
github-advanced-security[bot]
github-advanced-security bot found potential problems May 2, 2023
View reviewed changes
Lms24
Lms24 approved these changes May 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, this LGTM but in_app might also be overridden by stack trace processing. Which in turn is also influenced by source maps rewriting through Sentry CLI.

I don't have a lot of context on the original issue but if the source maps were uploaded with the webpack plugin (v1), we recently merged in a fix to Sentry CLI v1 which fixed a source maps rewriting bug for file names starting with webpack://. Perhaps this fixes it.

@lforst
Copy link
Copy Markdown
Contributor Author

lforst commented May 2, 2023

I don't have a lot of context on the original issue but if the source maps were uploaded with the webpack plugin (v1), we recently merged in a fix to Sentry CLI v1 which fixed a source maps rewriting bug for file names starting with webpack://. Perhaps this fixes it.

Wait, what was that bug again?

@Lms24
Copy link
Copy Markdown
Member

Lms24 commented May 2, 2023

This PR describes the fix. Tbh I'm not sure that this is related as this only surfaced in Angular apps but I guess depending on the webpack config it could emerge in other frameworks/builds as well.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 2, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.02 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 65.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.56 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 58.12 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.17 KB (0%)
@sentry/browser - Webpack (minified) 69.07 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.19 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.09 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.65 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.87 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.87 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 40.67 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 65.75 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 58.64 KB (+0.01% 🔺)

@lforst
Copy link
Copy Markdown
Contributor Author

lforst commented May 2, 2023

This PR describes the fix. Tbh I'm not sure that this is related as this only surfaced in Angular apps but I guess depending on the webpack config it could emerge in other frameworks/builds as well.

@Lms24 ah that looks unrelated. The stack traces look fine, it's just that we mark them as in_app false. Thanks for the heads-up though! :)

@Lms24
Copy link
Copy Markdown
Member

Lms24 commented May 2, 2023

It probably is unrelated. For the sake of completeness, I'm just realizing I didn't explain this properly. Because of the wrong source path caused by the bug I described above, the frames were incorrectly set to in_app: false regardless of if they were (forcefully) set to in_app: true in the code or not. So the SDK value didn't matter because it was overwritten during stracktrace processing based on the incorrectly processed source map.

But yeah, in_app: false in webpack just sounded oddly familiar to me which is why I brought it up. Feel free to merge this :)

@lforst lforst merged commit e0c3229 into develop May 3, 2023
@lforst lforst deleted the lforst-node-url-inapp branch May 3, 2023 13:18
billyvg pushed a commit that referenced this pull request May 5, 2023
@billyvg
fix(node): Mark stack frames with url protocol as in-app frames (#8008)
e38b32b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

+1 more reviewer

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitHub code mapping does not work in Next.js server side code

4 participants

@lforst @Lms24 @AbhiPrasad @github-advanced-security