feat(tracing): Use http.method for span data#7990
Merged
AbhiPrasad merged 1 commit intodevelopfrom May 2, 2023
Merged
Conversation
This was referenced Apr 28, 2023
Contributor
size-limit report 📦
|
mydea
approved these changes
May 2, 2023
srubin
pushed a commit
to descriptinc/sentry-javascript
that referenced
this pull request
May 2, 2023
Contributor
|
Wtf why did Next.js integration tests get skipped here. They should definitely run when there are changes in the browser package. |
lforst
pushed a commit
that referenced
this pull request
May 3, 2023
billyvg
pushed a commit
that referenced
this pull request
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following https://develop.sentry.dev/sdk/performance/span-data-conventions/, set
http.methodinstead ofmethodfor http spans generated by fetch/xhr.ref getsentry/team-webplatform-meta#60