test(loader): Ensure loader handles SDK being loaded in the meanwhile#7970
Merged
test(loader): Ensure loader handles SDK being loaded in the meanwhile#7970
Conversation
AbhiPrasad
approved these changes
Apr 26, 2023
Contributor
size-limit report 📦
|
Member
Author
|
So after some discussion, we decided to leave behavior as it is right now, and just add a test to make sure that even though the SDK is loaded twice, errors are only sent once, and the config is not overwritten. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test for the JS loader script to ensure we do not send errors multiple times if the SDK has been loaded in the meanwhile.