chore(ci): Add Node 20 to the test matrix#7904
Merged
AbhiPrasad merged 2 commits intodevelopfrom Apr 19, 2023
Merged
Conversation
Contributor
Author
|
Making CI even slower 😎 |
Lms24
approved these changes
Apr 19, 2023
Contributor
size-limit report 📦
|
Contributor
Author
|
In b4fe61f I removed Node 20 from the remix/next.js integration tests. Will create follow up issues for these. I think remix is also aware of Node 20 not being very cooperative: remix-run/remix#6099, let's wait till they get stuff fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/en/blog/announcements/v20-release-announce
From reviewing the CHANGELOG (https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V20.md), there seems to be no changes that will affect us in the code.
See v19 CHANGELOG: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V19.md
Notable things we can maybe pursue:
diagnostic_channelAPI https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V19.md#tracing-channel-in-diagnostic_channelPR to add node 18 to SDK Ci: #5049