feat(node): Auto-select best AsyncContextStrategy for Node.js version#7804
Merged
AbhiPrasad merged 2 commits intogetsentry:developfrom Apr 11, 2023
Merged
Conversation
9 tasks
AbhiPrasad
reviewed
Apr 11, 2023
AbhiPrasad
reviewed
Apr 11, 2023
| * Node.js >= 14 uses AsyncLocalStorage | ||
| * Node.js < 14 uses domains | ||
| */ | ||
| export function setNodeAsyncContextStrategy(): void { |
Contributor
There was a problem hiding this comment.
Can we get a sanity check test for this?
Collaborator
Author
There was a problem hiding this comment.
How do you mean? A test that checks that the version detection is working?
Contributor
There was a problem hiding this comment.
yup, but now that I think about it, it's maybe too complicated. We can add one any time later on.
Collaborator
Author
There was a problem hiding this comment.
Yeah, I'm surprised that there was no TypeScript or lint error from using if (NODE_VERSION >= 14)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically select the best
AsyncContextStrategyfor the Node.js version.AsyncLocalStorage