Skip to content

ref(core): Remove check for scope in _sendSessionUpdate#7693

Merged
AbhiPrasad merged 1 commit intodevelopfrom
abhi-hub-session-update-cleanup
Mar 31, 2023
Merged

ref(core): Remove check for scope in _sendSessionUpdate#7693
AbhiPrasad merged 1 commit intodevelopfrom
abhi-hub-session-update-cleanup

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad commented Mar 31, 2023

With the changes in #7551, this is no longer required. Let's save some bytes!

@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and mydea and removed request for a team March 31, 2023 11:42
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.66 KB (+0.22% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.52 KB (+0.2% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.2 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.89 KB (+0.21% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.57 KB (+0.15% 🔺)
@sentry/browser - Webpack (minified) 72.11 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.59 KB (+0.18% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.09 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.26 KB (+0.17% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.45 KB (+0.17% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.78 KB (+0.09% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.86 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.5 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.53 KB (+0.07% 🔺)

@AbhiPrasad
Copy link
Copy Markdown
Contributor Author

this doesn't seem right size bot 🤔

@Lms24
Copy link
Copy Markdown
Member

Lms24 commented Mar 31, 2023

this doesn't seem right size bot 🤔

i think size bot is off a lot lately...

@AbhiPrasad AbhiPrasad merged commit b5952df into develop Mar 31, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-hub-session-update-cleanup branch March 31, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants