chore(repo): Update craft config to add SvelteKit SDK release registry entry#7672
Merged
chore(repo): Update craft config to add SvelteKit SDK release registry entry#7672
Conversation
registry entry
Contributor
|
Do we also need to add this to master? |
AbhiPrasad
approved these changes
Mar 30, 2023
Member
Author
|
I don't think we need to because when releasing, we merge the changelog PR to master before creating the release branch. Last time I added the target for angular-ivy I also only merged it to develop: #7303 |
Contributor
|
The changelog PR was already merged - but we can also just wait since we have no docs yet. |
Member
Author
|
Yeah, I think it's fine to just skip this release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed I forgot to add SvelteKit to the release registry target in our craft config after we merged the first manual entry. We should be good to add the entry now as missing a version shouldn't be a problem.