feat(tracing): Add custom finishReason for when interaction is interrupted by another#7655
Merged
AbhiPrasad merged 4 commits intodevelopfrom Mar 30, 2023
Merged
Conversation
AbhiPrasad
approved these changes
Mar 29, 2023
AbhiPrasad
reviewed
Mar 29, 2023
|
|
||
| const op = 'ui.action.click'; | ||
| if (inflightInteractionTransaction) { | ||
| inflightInteractionTransaction._finishReason = 'interactionInterrupted'; |
Contributor
There was a problem hiding this comment.
this prob needs a ts-ignore.
Actually this also might break based on how we minify, so maybe we should just add a temporary setter for this.
Contributor
Author
There was a problem hiding this comment.
Thanks for the heads up, I'll add a custom setter instead 👍
AbhiPrasad
reviewed
Mar 29, 2023
| }, this._heartbeatInterval); | ||
| } | ||
|
|
||
| public setFinishReason(reason: string): void { |
Contributor
There was a problem hiding this comment.
Let's add a docstring that says @internal and then a big warning to say this will be changed/removed in future updates so don't use.
Contributor
Author
There was a problem hiding this comment.
Good call, added!
AbhiPrasad
approved these changes
Mar 29, 2023
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to track the frequency of this case, since we currently have no way of seeing it. When you click anywhere while another interaction transaction is still in progress, it gets finished. Therefore, we should add a new
finishReasonfor this case.Reminder that
_finishReasonis for the purpose of experimentation only and I will remove it later, please excuse any sloppiness regarding making_finishReasonpublic and setting its value externally 😄