fix(nextjs): Add loading component type to server component wrapping#7639
Merged
fix(nextjs): Add loading component type to server component wrapping#7639
Conversation
Lms24
approved these changes
Mar 29, 2023
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 29, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Is there anyway we can ensure that we are keeping track of new component types as they come out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #6726
We missed the
loading.tsxcomponent in the server component wrapping logic.