feat(tracing): Ensure pageload transaction starts at timeOrigin#7632
Merged
feat(tracing): Ensure pageload transaction starts at timeOrigin#7632
pageload transaction starts at timeOrigin#7632Conversation
lforst
approved these changes
Mar 28, 2023
Contributor
size-limit report 📦
|
Lms24
approved these changes
Mar 28, 2023
678dd8e to
b2867b4
Compare
AbhiPrasad
approved these changes
Mar 28, 2023
|
@mydea I think this PR broke some of custom metrics in our project. We use Is it expected behavior? |
Member
Author
|
Ugh, sorry about that! I will open a PR to fix this! |
Member
Author
|
Hi @langovoi , we've just released 7.49.0 which should fix this issue! sorry for the inconvenience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the
pageloadtransaction to ensure its start is always the timeOrigin.This should help with e.g. lazy loading sentry, where we still want this to be accurate.