build(cdn): Move tracing CDN bundle generation to @sentry/browser#7617
Merged
build(cdn): Move tracing CDN bundle generation to @sentry/browser#7617
@sentry/browser#7617Conversation
Now all (main) CDN bundle generation is in a single place.
Contributor
size-limit report 📦
|
Member
Author
|
I also updated the bundle build to run this in parallel for es5 & es6, as it is becoming quite slow. |
Member
Author
|
For reference, this exports a few more things in the tracing CDN bundle than before:
This explains the slightly increased bundle size, because it now includes:
Is this OK, or should this not be in the tracing CDN bundles? (it was always in the browser CDN bundles, AFAIK) |
@sentry/browser@sentry/browser
timfish
approved these changes
Mar 27, 2023
AbhiPrasad
approved these changes
Mar 27, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
It's important the bundles have unified exports, esp for the loader, so I think the bundle size increase is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now all (standalone) CDN bundle generation is in a single place.
This allows us to streamline the build process a bit, as this is now all inside of browser.
It also means we can get rid of the (IMHO a bit confusing)
PW_TRACING_ONLYflag for the browser integration tests. Now we just pass the bundle.Finally, integration tests that depend on tracing will now actually only run in a tracing-enabled CDN bundle, the same as we do this for replay. This does mean a bit more boilerplate in the tests, but actually makes it very explicit which CDN bundle supports what. Previously, we'd just use the tracing bundle even when running in non-tracing builds for these tests.