feat(tracing): Do not create interactions if navigation or pageload transaction active#7614
Merged
AbhiPrasad merged 7 commits intodevelopfrom Mar 30, 2023
Merged
Conversation
Contributor
size-limit report 📦
|
mydea
reviewed
Mar 27, 2023
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
AbhiPrasad
approved these changes
Mar 29, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
We can merge after lint is fixed!
Contributor
|
Pushed up linting fix so we can merge for release today. |
navigation or pageload transaction activenavigation or pageload transaction active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a slight annoyance where interaction transactions would still be created alongside a
pageloadornavigationtransaction. Both transactions at this point would have the same spans, so there's no need to duplicate them.This scenario occurs when clicking a link in an SPA, basically whenever
browserHistory.pushis being called to perform a soft navigation.