feat(node): Auto discovery only returns integrations where dependency loads#7603
Merged
AbhiPrasad merged 3 commits intogetsentry:developfrom Mar 24, 2023
Merged
Conversation
AbhiPrasad
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current auto discovery returns all integrations and they only become disables when
setupOnceis called.This means all the integrations are retained by the client and listed in sent envelopes.
This PR:
LazyLoadedIntegrationwhich adds aloadDependencymethod that allows us to preemptively load the dependency and check whether we should return the integrationLazyLoadedIntegration