Skip to content

fix(tracing): Account for case where startTransaction returns undefined#7566

Merged
AbhiPrasad merged 1 commit intodevelopfrom
abhi-trace-func-undefined
Mar 22, 2023
Merged

fix(tracing): Account for case where startTransaction returns undefined#7566
AbhiPrasad merged 1 commit intodevelopfrom
abhi-trace-func-undefined

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

if you have not enabled tracing extensions via addTracingExtensions, this function will not generate spans, and the span returned from the callback may be undefined.

@AbhiPrasad AbhiPrasad requested review from Lms24 and mydea March 22, 2023 12:53
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.44 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 63.52 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.57 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.65 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.85 KB (-0.21% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.77 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.08 KB (+0.06% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.21 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.39 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.95 KB (0%)

@AbhiPrasad AbhiPrasad merged commit 89b5720 into develop Mar 22, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-trace-func-undefined branch March 22, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants