fix(node): Consider tracing error handler for process exit#7558
Merged
AbhiPrasad merged 6 commits intogetsentry:developfrom Mar 22, 2023
Merged
fix(node): Consider tracing error handler for process exit#7558AbhiPrasad merged 6 commits intogetsentry:developfrom
AbhiPrasad merged 6 commits intogetsentry:developfrom
Conversation
AbhiPrasad
reviewed
Mar 21, 2023
…ntry-javascript into fix/tracing-node-exit
AbhiPrasad
approved these changes
Mar 21, 2023
Collaborator
Author
|
Oops, a function name is readonly in strict mode... |
Contributor
it's always the little things that get you 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We attempt to replicate node.js default behaviour of exiting when no error listeners are attached while ignoring Sentry's own listeners.
I noticed that the tracing error handler was not considered.
Magic strings don't feel the ideal way to do this but avoids adding exports to
@sentry/core.