feat(hub): Make scope always defined on the hub#7551
Merged
AbhiPrasad merged 1 commit intodevelopfrom Mar 21, 2023
Merged
Conversation
Contributor
size-limit report 📦
|
mydea
approved these changes
Mar 21, 2023
Member
mydea
left a comment
There was a problem hiding this comment.
LGTM! Good improvement, we should (eventually) also look into making client "required".
|
Just saw this! This is great, and lets me simplify my tracing wrapper, too, from the gist I posted for you a few weeks ago in #7387 (comment). FWIW, I agree with @mydea that it would be great to see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #7536, and trying to abstract it into a generic
Sentry.tracefunction I realized on unwieldy it is thathub.getScope()returnsScope | undefined.In practice this should never happen, since in the hub constructor we default to always setting a scope.
In this PR I change the signature of
hub.getScopeto return only aScope.This should be a bundle size decrease, and allow us to do some nice refactors across the board.
In addition, we can now add a trace function that looks like so: